Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure post abstraction methods use correct site ID. #1010

Merged
merged 14 commits into from
Feb 13, 2023
Merged

Ensure post abstraction methods use correct site ID. #1010

merged 14 commits into from
Feb 13, 2023

Commits on Jan 30, 2023

  1. Track site ID used to create object.

    @peterwilsoncc
    peterwilsoncc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    b010154 View commit details
    Browse the repository at this point in the history

  2. Add __call magic method to ensure site is correct.

    @peterwilsoncc
    peterwilsoncc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    1de7cdf View commit details
    Browse the repository at this point in the history

  3. Mock get_current_blog_id() for all tests.

    @peterwilsoncc
    peterwilsoncc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9ace708 View commit details
    Browse the repository at this point in the history

  4. Mock get_current_blog_id() for all tests.

    @peterwilsoncc
    peterwilsoncc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8085f6f View commit details
    Browse the repository at this point in the history

  5. Group magic methods.

    @peterwilsoncc
    peterwilsoncc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    8e6aa89 View commit details
    Browse the repository at this point in the history

  6. Only throw notice if WP_DEBUG is true.

    @peterwilsoncc
    peterwilsoncc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    1b9bac3 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Methods must be inaccessible for magic method to fire.

    @peterwilsoncc
    peterwilsoncc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3aaf4f5 View commit details
    Browse the repository at this point in the history

  2. Set the site ID even earlier.

    @peterwilsoncc
    peterwilsoncc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9189602 View commit details
    Browse the repository at this point in the history

  3. Note for developers.

    @peterwilsoncc
    peterwilsoncc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    4e0e09f View commit details
    Browse the repository at this point in the history

  4. Test only magic methods are public.

    @peterwilsoncc
    peterwilsoncc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b167b0d View commit details
    Browse the repository at this point in the history

  5. Cache results to avoid switching sites too many times.

    @peterwilsoncc
    peterwilsoncc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    dc19355 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Define methods available via the magic method.

    @peterwilsoncc
    peterwilsoncc committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1c4c2bf View commit details
    Browse the repository at this point in the history

  2. Note the need to add public methods to docblock.

    @peterwilsoncc
    peterwilsoncc committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1948031 View commit details
    Browse the repository at this point in the history

  3. Improve error messsages: i18n and phrasing.

    @peterwilsoncc
    peterwilsoncc committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    3aa72a1 View commit details
    Browse the repository at this point in the history