Bypass check_admin_referrer() call in the use_block_editor_for_post() #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2019 03:34
Since WordPress 5.1 will do a check_admin_referrer() inside the use_block_editor_for_posts(), and this call would fail and returns a 404 if there's custom meta box. Unsetting the 'meta-box-loader' in the global request would bypass that check.
|
PR looks good! It feels odd that we have to work around what feels like an upstream bug. I don't understand why the meta box check was added inside this function, might be worth investigating the origin further and perhaps opening an upstream PR to change. |
adamsilverstein
approved these changes
Mar 15, 2019
|
I verified this is an issue in the current version of WordPress & Distributor without any additional plugins. I tested in WordPress trunk with Distributor on the Steps to reproduce
Expected BehaviorSaving works. Actual BehaviorSaving fails with After this PR, saving works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since WordPress 5.0 will do a check_admin_referrer() inside the use_block_editor_for_posts(), this call would fail and kill the request if there's any custom meta boxes in the edit screen.
Unsetting the 'meta-box-loader' in the global request would bypass that check. Then, we will restore the value once we secured the date from the use_block_editor_for_posts() API.
This fixes the infinite saving / previewing on WordPress 5.0.