Enable wordpress.com Oath2 support #58

adamsilverstein · 2018-01-29T21:17:29Z

POC for review.

Add a new WordPressDotcomOauth2Authentication authentication type that supports posting to sites hosted on the .com infrastructure.
Add some UI manipulation to show the correct form fields on the add/edit external connection screen. Since OAuth requires several steps, and also requires a redirect URL (with a post id), we hide all fields initially so the connection is saved, then we show the two required connection fields: ID and secret. Finally, when a token has been retrieved and the connection is authenticated, we show the remaining connection options.

tomjn · 2018-01-29T21:46:15Z

Looks good from a reading of the code, but I haven't tested

…some language updates

…flow

… changed

tlovett1 · 2018-02-01T19:40:01Z

assets/js/src/admin-external-connection.js

+	var hideItemsRequiringAuth = function() {
+		oauthconnectionestablished = document.getElementsByClassName( 'oauth-connection-established' );
+		if ( 0 === oauthconnectionestablished.length ) {
+			$( '.hide-until-authed' ).hide();


Can we cache this selector?

tlovett1 · 2018-02-01T19:40:29Z

assets/js/src/admin-external-connection.js

+	$( externalConnectionTypeField ).on( 'change', function( event ) {
+		var slug = externalConnectionTypeField.value;
+
+		$( '.auth-credentials' ).hide();


Can we cache this selector?

tlovett1 · 2018-02-01T19:40:46Z

assets/js/src/admin-external-connection.js

+		$( changeCredentials ).on( 'click', function() {
+
+			// Show the credentials fields.
+			$( '.oauth-authentication-details-wrapper' ).show();


Can we cache this selector?

tlovett1 · 2018-02-01T19:41:20Z

assets/js/src/admin-external-connection.js

+
+		// Handle click to the wpdotcom begin-authorization button.
+		$( beginAuthorize ).on( 'click', function( event ) {
+				var $titleEl = $( document.getElementById( 'title' ) ),


There is already a selector for this

used that now

tlovett1 · 2018-02-01T19:42:05Z

includes/classes/Authentication.php

+	 *
+	 * @param string $error_message The error message to log.
+	 */
+	public static function log_authentication_error( $error_message ) {


I like this

tlovett1 · 2018-02-01T19:44:03Z

includes/classes/ExternalConnections/WordPressExternalConnection.php

@@ -312,15 +312,15 @@ public function push( $post_id, $args = array() ) {

 		if ( function_exists( 'vip_safe_wp_remote_get' ) ) {
 			$response = vip_safe_wp_remote_get(
-				$types_path, $this->auth_handler->format_get_args( array(


Why remove this?

hmm, i think that is a mistake, will restore

Fixed in f24fe0b

tlovett1 · 2018-02-06T05:45:09Z

@adamsilverstein here's my latest round of QA:

Duplicate external connection created
Step 1
- Button should say “Start Setup”
Step 2
- No error message for bad credentials
Step 3
- Need space after checkmark
- Clicked change connections, clicked Authorize Connection with empty secret, next screen says authorization was successful

…or class if empty.

…ault, return false to disable.

…on post pushes

tomjn

Things look alright, aside from merge conflicts, what else is needed at your end? Or is this pretty much done?

adamsilverstein · 2018-02-12T21:16:48Z

@tomjn Thanks... Yes, we have completed our internal review as well, and I will go ahead and get this merged. My next planned step is to commit the plugin with a client theme for a complete review; I will reference this pull request on the commit.

# Conflicts: # assets/css/sass/admin-external-connection.scss # assets/js/src/admin-external-connection.js # includes/classes/ExternalConnections/WordPressExternalConnection.php

Adam Silverstein added 4 commits December 6, 2017 08:56

Merge branch 'master' of github.com:10up/distributor

d262d3e

Merge branch 'master' of github.com:10up/distributor

17f2b81

Merge branch 'master' of github.com:10up/distributor

94cd3d2

Enable wordpress.com oath2 authentication

feca673

adamsilverstein requested a review from tlovett1 January 29, 2018 21:17

Adam Silverstein added 6 commits January 31, 2018 15:41

First step - save external connection via ajax for more seemless UX. …

332914a

…some language updates

Add a credentials_partial helper to remove redundant code & clean up …

8f3468b

…flow

Ensure current user can create post

94cefbb

Ensure newly saved connections get status ‘publish’

b260b3b

Better check four authorization complete

b505dde

Don’t re-auth when saving

12373e6

tomjn approved these changes Feb 1, 2018

View reviewed changes

Adam Silverstein added 10 commits February 1, 2018 12:00

Ajust some language and interactions

9683c17

first pass at wpdotcom auth docs

85f10e1

Handle the change credentials link.

6a38626

Don't attempt to authorize blank values.

8126ca0

improve logic for saving credentails, clearing token when auth fields…

d07ab0c

… changed

improve class naming

816c97d

correct doc typo

5a6c09c

Improve inline docs, code cleanup, whitespace etc

3ffac7a

ensure access token is set/update redirect url when saving

e3812a2

Correct issue authorizing new connections

c57c551

tlovett1 reviewed Feb 1, 2018

View reviewed changes

Adam Silverstein added 2 commits February 1, 2018 15:02

cache selectors where useful and reuse title selector

12233a0

undo change in WordPressExternalConnection::push

f24fe0b

Adam Silverstein added 3 commits February 6, 2018 08:58

Change first button to read ‘Start Setup’

d6b4f52

Adjust id on authorize button to avoid duplicate on page id

0bfa164

helper to validate a form field, ensuring it is non-empty. Add an err…

b49125a

…or class if empty.

Adam Silverstein and others added 15 commits February 6, 2018 09:35

validate field when create connection is clicked

8dd0a86

use validateField helper for title

9bbce4f

use cached clientSecret selector

091196c

In log_authentication_error add an admin notice callback and display

c65bab7

Display any authorization or token errors.

ff065a5

Add space after connected checkmark

406f2e5

add error style for password field

a41a250

pass the event to validateField

99173e3

Filter whether the network connection type is enabled. Enabled by def…

45a2178

…ault, return false to disable.

remove stray semicolon

4cb85cf

Control network connection load with filter

bdacb9c

Merge branch 'master' of github.com:10up/distributor

192fff5

Adjust calls to vip_safe_wp_remote_get, fix arguments

4039516

Add a filter to filter the timeout used for WordPressExternalConnecti…

7eb01b6

…on post pushes

clean up new connection creation

e021575

tomjn reviewed Feb 12, 2018

View reviewed changes

Adam Silverstein added 4 commits February 13, 2018 08:18

Merge branch 'master' into feature/enable-wordpressdotcom-oath2-auth

02e7671

# Conflicts: # assets/css/sass/admin-external-connection.scss # assets/js/src/admin-external-connection.js # includes/classes/ExternalConnections/WordPressExternalConnection.php

Bring over JavaScript and CSS after restructure in master

531012b

cleanup after restructure, linting

cecee79

Cleanup: inline docs, indendation, whitespace

9b1d3a0

adamsilverstein merged commit fccef78 into master Feb 13, 2018

adamsilverstein mentioned this pull request Feb 14, 2018

OAuth2 Authentication #46

Closed

robbiet480 mentioned this pull request Feb 23, 2018

Implementing alternate long term authentication solutions #69

Open

tlovett1 deleted the feature/enable-wordpressdotcom-oath2-auth branch April 10, 2018 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable wordpress.com Oath2 support #58

Enable wordpress.com Oath2 support #58

adamsilverstein commented Jan 29, 2018

tomjn commented Jan 29, 2018

tlovett1 Feb 1, 2018

adamsilverstein Feb 1, 2018

tlovett1 Feb 1, 2018

adamsilverstein Feb 1, 2018

tlovett1 Feb 1, 2018

adamsilverstein Feb 1, 2018

tlovett1 Feb 1, 2018

adamsilverstein Feb 1, 2018

tlovett1 Feb 1, 2018

adamsilverstein Feb 1, 2018

tlovett1 Feb 1, 2018

adamsilverstein Feb 1, 2018

adamsilverstein Feb 1, 2018

tlovett1 commented Feb 6, 2018 •

edited

tomjn left a comment

adamsilverstein commented Feb 12, 2018

Enable wordpress.com Oath2 support #58

Enable wordpress.com Oath2 support #58

Conversation

adamsilverstein commented Jan 29, 2018

tomjn commented Jan 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tlovett1 commented Feb 6, 2018 • edited

tomjn left a comment

Choose a reason for hiding this comment

adamsilverstein commented Feb 12, 2018

tlovett1 commented Feb 6, 2018 •

edited