Set empty action in bulk action dropdown #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkotter
reviewed
Feb 15, 2021
includes/classes/PullListTable.php
Outdated
| @@ -527,6 +527,7 @@ public function column_cb( $post ) { | |||
| public function get_bulk_actions() { | |||
| if ( empty( $_GET['status'] ) || 'new' === $_GET['status'] ) { // @codingStandardsIgnoreLine Nonce not required. | |||
| $actions = [ | |||
| '-1' => esc_html__( 'Bulk Action', 'distributor' ), | |||
There was a problem hiding this comment.
Minor change but I think the text here should be Bulk actions to match what WordPress uses elsewhere
|
@dhanendran Left one minor comment but otherwise, this looks good. Thanks! |
|
@dkotter I have addressed your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
We have the
Pullaction as the default action on the bulk dropdown, whenever we click theApplybutton the page sends both top and bottom form to the server irrespective of the button we clicked. Since bothactionandaction2has values, WP always takes the value of `action'. Now I have added a empty option as like the post list page to fix this issue.Checklist:
Applicable Issues
#610