-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/875 Transition from WP Acceptance to Cypress E2E tests #900
Conversation
I'll move this to the 2.0.0 milestone as 1.7.0 likely to be released early next week. |
to fix: npm ERR! git@github.com: Permission denied (publickey). npm ERR! fatal: Could not read from remote repository.
We discussed this issue in the 10up APAC call today. It appears that Cypress is not building either because:
To ensure users are using the same version of node, it would be good to add an If Cypress requires a specific version of node, then let's aim for 16, 14 or 12 in order of preference -- each of them being LTS versions. |
I'm wildly opinionated that we should do what is necessary to ensure we can utilize Cypress for e2e tests on Distributor since we're spending time on building up our Cypress utilities across other 10up OSS projects and would be sub-optimal to have a different e2e testing framework just with Distributor. So if that means adding an |
As discussed today, the failing Dependency Review check is already solved in #916, so that doesn't need addressed here. In addition, it was decided that we should proceed with merging this and any additional changes need (like additional test coverage, removing WP Acceptance tests, etc) can be handled in follow up PRs. |
Description of the Change
Adding Cypress E2E tests and removing WP Acceptance tests.
Added the following tests:
Closes #875
Alternate Designs
n/a
Possible Drawbacks
n/a
Verification Process
Check if all Cypress tests are running locally + at Github actions.
Checklist:
Changelog Entry
Credits
Props @faisal-alvi