Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show distributed author name when fetch author display name with get_the_author_meta #952

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

ravinderk
Copy link
Contributor

@ravinderk ravinderk commented Sep 30, 2022

Description of the Change

I find out that developer can use get_the_author_meta('display_name') function to get author name. I added a filter to return distributed author name.

Closes #868

How to test the Change

I tested the post author name on the post page on the following themes:

Theme Override byline
Twenty-Twenty
Twenty-Twenty-One
Twenty-Twenty-Two

Changelog Entry

Fixed - Return distributed author name when use get_the_author_meta('display_name') function

Credits

Props @cadic, @ravinderk, @iamdharmesh, @mapamond.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Distributed author name should return when use get_the_author_meta('display_name').
@ravinderk ravinderk marked this pull request as ready for review September 30, 2022 12:31
@ravinderk ravinderk requested review from a team and iamdharmesh and removed request for a team and iamdharmesh September 30, 2022 12:32
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @ravinderk, LGTM 🚀

@jeffpaul jeffpaul added this to the 2.0.0 milestone Oct 4, 2022
@ravinderk ravinderk merged commit 74ba9c5 into develop Oct 5, 2022
@ravinderk ravinderk deleted the fix/868 branch October 5, 2022 05:44
@peterwilsoncc peterwilsoncc modified the milestones: 2.0.0, 1.9.0 Dec 13, 2022
peterwilsoncc pushed a commit that referenced this pull request Dec 13, 2022
Show distributed author name when fetch author display name with get_the_author_meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author name sync/not distributed
4 participants