Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from using the term blacklist to excluded #961

Merged
merged 5 commits into from Oct 21, 2022

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Oct 19, 2022

Description of the Change

There's a handful of places we were using the term blacklist. To be more inclusive (and more descriptive), this PR changes those to use the term excluded.

There was one utility function and one filter that used the term blacklist. I've added deprecations for both of those, though we may be safe to just completely remove/rename the function (more likely though that the filter is being used).

Note also there's a handful of places that will need version numbers updated before we release this. I've left those as X.X.X for now.

Closes #960

How to test the Change

Nothing that really needs tested here, though could test the meta exclusion piece to ensure nothing broke there (though this should just be name changes, no functionality changes).

Changelog Entry

Changed - Change uses of blacklist and use exclude instead
Deprecated - Deprecate the Distributor\Utils\blacklisted_meta function and the dt_blacklisted_meta filter

Credits

Props @dkotter, @jeffpaul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 2.0.0 milestone Oct 19, 2022
@dkotter dkotter self-assigned this Oct 19, 2022
Copy link
Collaborator

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one note inline which I'll self merge.

includes/utils.php Show resolved Hide resolved
@peterwilsoncc peterwilsoncc merged commit f76fd08 into develop Oct 21, 2022
@peterwilsoncc peterwilsoncc deleted the fix/rename-blacklist branch October 21, 2022 00:38
@peterwilsoncc peterwilsoncc modified the milestones: 2.0.0, 1.9.0 Dec 13, 2022
peterwilsoncc added a commit that referenced this pull request Dec 13, 2022
Change from using the term `blacklist` to `excluded`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update usages of blacklist to be more inclusive
2 participants