Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to better conform to WP Coding Standards #120

Merged
merged 4 commits into from Aug 1, 2023

Conversation

bmarshall511
Copy link
Contributor

Description of the Change

Lots of code updates to better conform to WordPress Coding Standards.

Closes #118

How to test the Change

Changelog Entry

Fixed - Misc. code updates to better conform to WordPress Coding Standards

Credits

Props @bmarshall511

Checklist:

@bmarshall511 bmarshall511 requested a review from a team as a code owner June 27, 2023 12:38
@bmarshall511 bmarshall511 self-assigned this Jun 27, 2023
@bmarshall511 bmarshall511 requested review from Sidsector9 and removed request for a team June 27, 2023 12:38
@jeffpaul jeffpaul added this to the 1.3.0 milestone Jun 27, 2023
@Sidsector9
Copy link
Member

Sidsector9 commented Jul 11, 2023

@bmarshall511 I confirmed here that the tests pass on develop but are failing on this branch. Can you fix them?

@bmarshall511 bmarshall511 marked this pull request as draft July 13, 2023 17:52
@bmarshall511
Copy link
Contributor Author

@Sidsector9 Fixed the failing test. There's still a handful of files that still need to be touched to better conform to standards, but leaving as is for now until #117 gets merged to avoid a bunch of potential conflicts.

Side note, this handles about 90% of the coding standard errors. There's still some that'll require a larger lift (i.e restructuring classes, adding nonces, renaming hooks, etc.), but probably better to handle those in a separate PR.

Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's no problem, we can handle the remaining 10% in a separate PR. Thanks for fixing the tests 👍

@Sidsector9 Sidsector9 marked this pull request as ready for review July 19, 2023 07:10
Sidsector9
Sidsector9 previously approved these changes Jul 19, 2023
@bmarshall511
Copy link
Contributor Author

@Sidsector9 Fixed the failing test. There's still a handful of files that still need to be touched to better conform to standards, but leaving as is for now until #117 gets merged to avoid a bunch of potential conflicts.

Side note, this handles about 90% of the coding standard errors. There's still some that'll require a larger lift (i.e restructuring classes, adding nonces, renaming hooks, etc.), but probably better to handle those in a separate PR.

@Sidsector9 Got this updated with develop and fixed those handful of files.

@Sidsector9 Sidsector9 merged commit b3cc852 into develop Aug 1, 2023
6 of 7 checks passed
@Sidsector9 Sidsector9 deleted the fix/coding-standards-ben branch August 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code to conform to WP coding standards
3 participants