Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: display correct title when creating new section #62

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Fix: display correct title when creating new section #62

merged 1 commit into from
Sep 23, 2020

Conversation

dinhtungdu
Copy link
Collaborator

Description of the Change

This PR fixes issue found here: #54 (comment)

issue creating Sections within Print Issues, name entered for Section does not save and Template is used by default instead

Verification Process

  1. Upgrade WP to 5.5.1
  2. Create a new section.
  3. See the section title displays correctly.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

@jeffpaul jeffpaul added this to the 1.1.2 milestone Sep 23, 2020
@jeffpaul jeffpaul merged commit bf3ddba into develop Sep 23, 2020
@jeffpaul jeffpaul deleted the fix/section-title branch September 30, 2020 01:49
@jeffpaul jeffpaul mentioned this pull request Sep 30, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dinhtungdu @dkotter @jeffpaul