Use DIRECTORY_SEPARATOR instead of slash in filepaths #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Use the PHP constant
[DIRECTORY_SEPARATOR](https://www.php.net/manual/en/dir.constants.php)
(which is/
on *nix, and\
on windows) instead of/
in filepaths.Without this, the plugin doesn't work on Windows machines: EDW thinks the modules aren't defined and so doesn't try to activate them, so the "Print" admin page doesn't appear. See https://i.imgur.com/9n1CqO0.png
Alternate Designs
You could alternatively do a string replace to standardize which slashes are used. This seemed simpler.
Benefits
EDW can now work on Windows machines, including localhost installs.
Possible Drawbacks
Verification Process
I tested this on Windows (see https://i.imgur.com/ANd5ut7.png) and on a Linux machine.
I'm able to create a print edition zip.
Checklist:
Applicable Issues
Should address #73