Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle fixing of multiple different instances of insecure content #139

Merged
merged 2 commits into from Aug 28, 2023
Merged

Properly handle fixing of multiple different instances of insecure content #139

merged 2 commits into from Aug 28, 2023

Conversation

kmgalanakis
Copy link
Contributor

Description of the Change

In this MR I'm properly handling the fixing and highlighting of multiple different instances of insecure content in the same post.

Closes #138

How to test the Change

See the reproduction steps at #138

Changelog Entry

Fixed - Properly handle fixing of multiple different instances of insecure content

Credits

Props @kmgalanakis

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@kmgalanakis kmgalanakis requested a review from a team as a code owner August 17, 2023 14:52
@kmgalanakis kmgalanakis requested review from iamdharmesh and removed request for a team August 17, 2023 14:52
@kmgalanakis kmgalanakis self-assigned this Aug 17, 2023
@jeffpaul jeffpaul added this to the 1.2.0 milestone Aug 17, 2023
iamdharmesh
iamdharmesh approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @kmgalanakis. LGTM!

@jeffpaul jeffpaul merged commit 4052423 into develop Aug 28, 2023
4 of 8 checks passed
@jeffpaul jeffpaul deleted the fix/only-the-first-instance-of-insecure-content-is-fixed branch August 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@kmgalanakis kmgalanakis

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Only the first instance of insecure content is fixed
3 participants
@kmgalanakis @iamdharmesh @jeffpaul