Fixed: Map js loading everywhere

[jayedul]

Description of the Change

Map js library was loading everywhere. Now it is fixed.

Closes #147

How to test the Change

• Create a page or post
• Add Apple Map block
• Save and visit
• Open network log and make sure https://cdn.apple-mapkit.com/mk/5.x.x/mapkit.js is loading
• Now edit the post, remove the map block, save and visit again
• Now you should see the library is not loading anymore. Previously it used load even though there is no map block in the post.

Changelog Entry

Fixed - Mapkit js loading everywhere in frontend despite no Map block there is

Credits

Props @jayedul

Checklist:

• I agree to follow this project's Code of Conduct.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests pass.

[fabiankaegy]

Thanks for your contribution :)

The change currently only adds the apple-mapkit-js dependencie to the editor script of the block. However it also needs to be present in the script we load on the frontend via the viewScript handle: maps-block-apple-frontend

However I still don't quite understand why the script is loading everywhere. As per the documentation any WPDefinedAsset loaded via the script key should only be enqueued in the editor and on the frontend if the block is actually being used. https://github.com/WordPress/gutenberg/blob/trunk/docs/reference-guides/block-api/block-metadata.md#script

[jayedul]

apple-mapkit-js is already used as dependency for frontend.

However, I'm also unsure why the file loads everywhere when it was registered with script key.

[jeffpaul]

@fabiankaegy @jayedul is there still work needed here or can this move along in review and towards merge?

[jeffpaul]

@10up/open-source-practice would be good if someone could help get this through review/merge... thanks!

[faisal-alvi]

LGTM

Working as expected:

IMO, no more work is required; looks good to merge.