Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test on built zip #163

Merged
merged 4 commits into from Apr 3, 2023
Merged

E2E test on built zip #163

merged 4 commits into from Apr 3, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Mar 20, 2023

Description of the Change

PR contains changes to Run E2E tests on the zip generated by "Build release zip" action to catch release zip bugs early and at the PR level instead of manual testing before release.

Closes #151

Changelog Entry

Changed - Run E2E tests on the zip generated by "Build release zip" action.

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Mar 20, 2023
@jayedul jayedul marked this pull request as ready for review March 20, 2023 16:46
@jayedul jayedul requested review from jeffpaul, a team and fabiankaegy as code owners March 20, 2023 16:46
@jeffpaul jeffpaul added this to the 1.1.1 milestone Mar 20, 2023
@jeffpaul jeffpaul requested review from a team and peterwilsoncc and removed request for a team and jeffpaul March 20, 2023 19:16
peterwilsoncc
peterwilsoncc reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, re-running the E2E workflow shows the build step runs as expected.

I've dropped a note inline about using the override file rather than dirtying the repo.

.github/workflows/cypress.yml Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
tests/bin/set-wp-config.js Show resolved Hide resolved
peterwilsoncc
peterwilsoncc approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@jeffpaul jeffpaul merged commit 496efa4 into develop Apr 3, 2023
13 checks passed
@jeffpaul jeffpaul deleted the update/151 branch April 3, 2023 21:51
@jayedul jayedul mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@jayedul jayedul

Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

Run E2E tests on the zip generated by "Build release zip" action.
3 participants
@jayedul @peterwilsoncc @jeffpaul