Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the Apple Maps block works fine in WP 6.4 #183

Merged
merged 2 commits into from Oct 6, 2023
Merged

Ensure that the Apple Maps block works fine in WP 6.4 #183

merged 2 commits into from Oct 6, 2023

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Oct 4, 2023 •
edited by jeffpaul

Description of the Change

PR fixes the Apple Maps block error in WP 6.4-beta2 when MapKit Credentials are not configured.

For more information on the root cause of the issue please check the issue description here.

image

Closes #182

How to test the Change

  1. Install and activate the plugin on WP 6.4-beta-2
  2. Keep Mapkit js credentials blank
  3. Go to create post/page and add "Apple Maps" block
  4. Verify Apple Maps block working fine without any errors.

Changelog Entry

Fixed - Ensure that the Apple Maps block works fine in WordPress 6.4.

Credits

Props @iamdharmesh @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh requested review from fabiankaegy and a team as code owners October 4, 2023 10:48
@iamdharmesh iamdharmesh requested review from faisal-alvi and removed request for a team October 4, 2023 10:48
@iamdharmesh iamdharmesh self-assigned this Oct 4, 2023
@iamdharmesh iamdharmesh added this to the Future Release milestone Oct 4, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 1.2.0 Oct 4, 2023
faisal-alvi
faisal-alvi approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@faisal-alvi faisal-alvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamdharmesh thanks for the work, LGTM.

in develop:

image

in fix/182:

image

fabiankaegy
fabiankaegy approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@fabiankaegy fabiankaegy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes :)

@fabiankaegy fabiankaegy merged commit bc5690c into develop Oct 6, 2023
10 of 13 checks passed
@fabiankaegy fabiankaegy deleted the fix/182 branch October 6, 2023 09:54
@dkotter dkotter modified the milestones: 1.2.0, 1.1.2 Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiankaegy fabiankaegy fabiankaegy approved these changes

@faisal-alvi faisal-alvi faisal-alvi approved these changes

Assignees

@iamdharmesh iamdharmesh

Labels
None yet
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

Apple Maps block gives error in WP 6.4-beta2 if MapKit Credentials is not configured.
5 participants
@iamdharmesh @fabiankaegy @faisal-alvi @dkotter @jeffpaul