Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix only users that have capability to manage_options can change auth settings #29

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

fabiankaegy
Copy link
Member

From now on only users that can manage_options actually can set / change the Apple Auth settings. Other Users will get a prompt telling them to contact their Administrator.

Applicable Issues

#27

Changelog Entry

Modify permissions so only users with the capability to manage_options can change the authentication keys required for the Apple Maps Plugin to work.

@fabiankaegy fabiankaegy added the type:enhancement New feature or request. label Jun 12, 2020
@fabiankaegy fabiankaegy added this to the 0.1.0 milestone Jun 12, 2020
@jeffpaul jeffpaul linked an issue Jun 12, 2020 that may be closed by this pull request
Copy link
Contributor

@ryanwelcher ryanwelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! However, I do think that we still need a dedicated settings/setup wizard but we can address that in a separate issue/PR.

src/helper.js Outdated Show resolved Hide resolved
Co-authored-by: Ryan Welcher <ryan.welcher@10up.com>
@ryanwelcher ryanwelcher merged commit 8581118 into develop Jun 19, 2020
@jeffpaul jeffpaul deleted the feature/restrict-editing-to-admin branch June 24, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict editing of options to "manage_options"
3 participants