Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add wp env for local development #77

Merged
merged 5 commits into from
Oct 13, 2021

Conversation

fabiankaegy
Copy link
Member

Description of the Change

In order to make it easier to get up and running and to contribute to the project I have added the @wordpress/env package with configuration to allow using npm run wp-env start to spin up a local WordPress environment to work on the plugin.

@jeffpaul jeffpaul requested a review from helen September 30, 2020 13:15
@jeffpaul jeffpaul added this to the 1.1.0 milestone Sep 30, 2020
dinhtungdu
dinhtungdu previously approved these changes Oct 3, 2020
Copy link
Collaborator

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me! 👍

@fabiankaegy fabiankaegy changed the base branch from develop to trunk October 3, 2020 17:12
@jeffpaul jeffpaul changed the base branch from trunk to develop May 7, 2021 16:11
@jeffpaul jeffpaul dismissed dinhtungdu’s stale review May 7, 2021 16:11

The base branch was changed.

@jeffpaul
Copy link
Member

@fabiankaegy mind resolving the merge conflict so this can get merged in?

@jeffpaul
Copy link
Member

@fabiankaegy may be worth a note in the README.md that this is available, then resolving merge conflicts, then can probably merge in.

@fabiankaegy
Copy link
Member Author

@jeffpaul I have rebased this PR and added some documentation to the CONTRIBUTING.md file

@jeffpaul jeffpaul merged commit e30df19 into develop Oct 13, 2021
@jeffpaul jeffpaul deleted the feature/add-wp-env-for-local-development branch October 13, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants