Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/145 Use Node 16 for a Release action #146

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix/145 Use Node 16 for a Release action #146

merged 1 commit into from
May 15, 2023

Conversation

faisal-alvi
Copy link
Member

Description of the Change

The solution for the linked issue is to downgrade the node version to 16 or below. As they suggested at GoogleChromeLabs/squoosh#1033 (comment):

For anyone running into the same problem: Temporarily downgrading to node >=v16 when using @squoosh/lib@0.4.0 is a successful workaround. Thank you 💪

Also they are not planning to support squoosh any more so it is better to downgrade node for now. GoogleChromeLabs/squoosh#1242 (comment):

Unfortunately, due to a few people leaving the team, and staffing issues resulting from the current economic climate (ugh), the CLI and libsquoosh packages are no longer actively maintained. I know that sucks, but there simply isn't the time & people to work on this. If anyone from the community wants to fork it, you have my blessing. The squoosh.app web app will continue to be supported and improved.

Closes #145

How to test the Change

This can be tested upon the next release.

Changelog Entry

Fixed - Node engine 18 unsupported for @squoosh/lib causing Release failure

Credits

Props @faisal-alvi

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@faisal-alvi faisal-alvi requested a review from a team May 15, 2023 11:31
@faisal-alvi faisal-alvi self-assigned this May 15, 2023
@github-actions github-actions bot added the needs:code-review This requires code review. label May 15, 2023
@faisal-alvi faisal-alvi requested a review from dkotter May 15, 2023 11:34
@faisal-alvi faisal-alvi mentioned this pull request May 15, 2023
17 tasks
@faisal-alvi faisal-alvi merged commit 6365ddc into develop May 15, 2023
@faisal-alvi faisal-alvi deleted the fix/145 branch May 15, 2023 14:15
@jeffpaul jeffpaul added this to the 1.3.3 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node engine 18 unsupported for @squoosh/lib causing Release failure
3 participants