Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release instructions #195

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Update release instructions #195

merged 2 commits into from
Oct 16, 2020

Conversation

jeffpaul
Copy link
Member

Description of the Change

Adds note to release instructions that we should be targeting the master branch for releases as GitHub tries to trick you into picking develop. Nasty GitHub.

Alternate Designs

none.

Benefits

Avoid confusion for future new contributors/maintainers shipping releases.

Possible Drawbacks

none identified.

Verification Process

Manually verified via GitHub web UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

none, sorry

Changelog Entry

n/a

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Nov 20, 2019
@jeffpaul jeffpaul added this to the 2.0.0 milestone Nov 20, 2019
@jeffpaul jeffpaul requested a review from helen November 20, 2019 19:08
@jeffpaul jeffpaul self-assigned this Nov 20, 2019
@jeffpaul jeffpaul requested review from tlovett1 and removed request for helen November 20, 2019 19:09
dinhtungdu
dinhtungdu approved these changes Jan 28, 2020
View reviewed changes
Copy link
Collaborator

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jeffpaul jeffpaul merged commit d4e5dda into develop Oct 16, 2020
@jeffpaul jeffpaul deleted the update/release-steps branch January 7, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

@tlovett1 tlovett1 Awaiting requested review from tlovett1

Assignees

@jeffpaul jeffpaul

Labels
needs:documentation This requires documentation.
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffpaul @dinhtungdu