Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Correct the snippet to enable loop detection #207

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Docs: Correct the snippet to enable loop detection #207

merged 1 commit into from
Jun 4, 2020

Conversation

dinhtungdu
Copy link
Collaborator

Description of the Change

This PR corrects the snippet to enable redirect loop detection in our docs.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #206

Changelog Entry

@dinhtungdu dinhtungdu self-assigned this May 7, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone May 7, 2020
@jeffpaul jeffpaul added the needs:documentation This requires documentation. label May 7, 2020
@jeffpaul jeffpaul self-requested a review May 7, 2020 13:51
@jeffpaul
Copy link
Member

jeffpaul commented May 7, 2020

Making a note here to prop the issue reporter in the changelog when we tag this change into a release.

jeffpaul
jeffpaul approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeffpaul jeffpaul merged commit 1855dd7 into develop Jun 4, 2020
@jeffpaul jeffpaul deleted the docs/redirect-loop-detection branch January 7, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul jeffpaul approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
needs:documentation This requires documentation.
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.

Loop detection
2 participants
@dinhtungdu @jeffpaul