Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/assets #209

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Update/assets #209

merged 5 commits into from
Oct 16, 2020

Conversation

jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Jun 8, 2020

Description of the Change

This PR updates the plugin banner and icon assets to be more in line with our modern plugin branding styles as well as removes the blurry English-only text from the banner image. We only have the smaller size banner image currently, so this PR also introduces the larger banner image and an icon SVG file as well.

Alternate Designs

Keep as-is.

Benefits

Ensures we limit English text from banner, ensures all images are available at required filesizes, and updates branding to modern 10up styles.

Possible Drawbacks

If anyone is expecting to find the older banner or icon, then the change could be jarring or confusing.

Verification Process

Manually verified via thee GitHub Desktop UI.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a

Changelog Entry

### Added
- Banner and icon images (props @lea10up)

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Jun 8, 2020
@jeffpaul jeffpaul added this to the 2.0.0 milestone Jun 8, 2020
@jeffpaul jeffpaul requested review from helen and tlovett1 June 8, 2020 03:59
@jeffpaul jeffpaul self-assigned this Jun 8, 2020
@jeffpaul jeffpaul merged commit 30d4fb0 into develop Oct 16, 2020
@jeffpaul jeffpaul deleted the update/assets branch January 7, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant