Add 410 support, make status codes filterable #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helen
reviewed
Nov 17, 2020
inc/functions.php
Outdated
| array() | ||
| ); | ||
|
|
||
| return $status_codes + array_diff_key( $additional_status_codes, $status_codes ); |
There was a problem hiding this comment.
I think this is okay but I just want to double check that PHP 8 won't get mad about + as an array operator.
There was a problem hiding this comment.
I tested + against php-8.0.0rc4 and I don't see any problem. The site I used to test is: https://3v4l.org/
helen
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds:
410 Gonestatus code to the list of HTTP status codes.srm_additional_status_codesthat allows developer add status codes.Verification Process
Checklist:
Applicable Issues
Fixes #205.
Changelog Entry