Fix required parameter message in PHP 8.0

[vinkla]

Description of the Change

This fixes the following message:

Deprecated: Required parameter $post follows optional parameter $actions in safe-redirect-manager/inc/classes/class-srm-post-type.php on line 98

$post can be either int|WP_Post|null: https://developer.wordpress.org/reference/functions/get_post_type/

Alternate Designs

N/A

Benefits

The message will now longer be visible.

Possible Drawbacks

N/A

Verification Process

I tried to update the plugin in a local WordPress application running PHP 8.0.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Applicable Issues

Changelog Entry

Fix required parameter following optional deprecated message in PHP 8

[dinhtungdu]

Hi @vinkla, thank you for the PR.

Can you please address the phpcs issue?

About the parameters, I think we should not define $actions as an optional parameter. It's a hook so the $actions will be always defined already. So I suggest removing the default value of $actions instead. What do you think?

[vinkla]

Can you please address the phpcs issue?

Didn't notice the error. Should be fixed now.

About the parameters, I think we should not define $actions as an optional parameter. It's a hook so the $actions will be always defined already. So I suggest removing the default value of $actions instead. What do you think?

I'm guessing it would require a major release if we remove the default value? Maybe it could be added as a TODO for the next major release?

[dinhtungdu]

I'm guessing it would require a major release if we remove the default value? Maybe it could be added as a TODO for the next major release?

That method is used for the filter only, so it's safe to change the parameter to not optional. Even it's used by themes or other site plugins, it's safe too because the second parameter is not optional, so the first one is always passed already. So I think we can change it now.

cc @tlovett1

[vinkla]

I've update the pull request. Even if it is only used internally it could break any other packages extending this plugin.

[dinhtungdu]

Thank you @vinkla for your contribution!