Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #145 #242

Merged
merged 4 commits into from
Jul 13, 2021
Merged

Fixes #145 #242

merged 4 commits into from
Jul 13, 2021

Conversation

sultann
Copy link
Contributor

@sultann sultann commented May 23, 2021

The PR fixes the issue Redirect Limits #145.

  • Separate function for redirection limit
  • Increased limit to 1000
  • Transient cache key changed as per the limit

@sultann sultann self-assigned this May 23, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu May 24, 2021 18:07
@jeffpaul jeffpaul added this to the 1.10.1 milestone May 24, 2021
@jeffpaul jeffpaul requested a review from dinhtungdu June 1, 2021 19:27
@jeffpaul jeffpaul linked an issue Jun 22, 2021 that may be closed by this pull request
Copy link
Collaborator

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me now!

In b8f9b51, I fixed the cache flushing issue caused by the new transient name format.

@jeffpaul jeffpaul merged commit b7530e0 into develop Jul 13, 2021
@jeffpaul jeffpaul deleted the fix/145 branch July 13, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect Limits
3 participants