Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: $parsed_requested_path['path'] doesn't always exits #246

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Conversation

dinhtungdu
Copy link
Collaborator

@dinhtungdu dinhtungdu commented Jul 6, 2021

Description of the Change

In #196 we add a feature to redirect URL with params. We parse URL in that feature and assume that the parsed path always exists, but parse_url can return false in some edge cases. So this PR adds a check to cover those cases.

Fixes #244.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@dinhtungdu dinhtungdu self-assigned this Jul 6, 2021
@dinhtungdu dinhtungdu requested a review from dkotter July 6, 2021 03:48
@jeffpaul jeffpaul added this to the 1.10.1 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants