Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E testing with Cypress #262

Merged
merged 19 commits into from Apr 18, 2022
Merged

E2E testing with Cypress #262

merged 19 commits into from Apr 18, 2022

Conversation

iamdharmesh
Copy link
Member

@iamdharmesh iamdharmesh commented Mar 22, 2022

Description of the Change

Closes #261

This PR removes wpacceptance tests and Adds end-to-end testing with Cypress to follow OSBP guide. Test runs automatically on every pull request to the develop branch.

Steps to perform local testing or develop new tests:

  1. Install dependencies npm install
  2. Start wp-env local development suite npm run env:start
  3. Run cypress npm run cypress:run or open developer browser npm run cypress:open

Added Tests:

  • Activate plugin.
  • Check menu item under Tools menu.
  • Visit "Safe Redirect Manager" page.
  • Create a redirect rule.
  • Test redirect with below rules
    • Normal
    • Wildcard
    • Regex

Verification Process

GitHub Actions workflow "E2E test", expected to pass the test. Refer to "Description of the Change" for local testing.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Add - End-to-end testing with Cypress

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this Mar 22, 2022
@jeffpaul jeffpaul added this to the Future Release milestone Mar 22, 2022
@iamdharmesh iamdharmesh marked this pull request as ready for review March 23, 2022 14:50
@iamdharmesh iamdharmesh requested review from a team and Sidsector9 and removed request for a team March 23, 2022 14:51
@jeffpaul jeffpaul modified the milestones: Future Release, 2.0.0 Apr 11, 2022
Copy link
Member

@Sidsector9 Sidsector9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise. Just requires a sync with the base branch.

@iamdharmesh iamdharmesh merged commit e2a7472 into develop Apr 18, 2022
@iamdharmesh iamdharmesh deleted the test/261 branch April 18, 2022 07:16
@jeffpaul jeffpaul modified the milestones: 2.0.0, 1.10.2 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Setup Cypress for E2E testing
3 participants