Deprecated error in importing fix #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Sidsector9
reviewed
Jul 11, 2023
There was a problem hiding this comment.
@jayedul this plugin has a minimum PHP support for 7.4. The auto_detect_line_endings directive was deprecated in 8.1 and will be removed in 9.0.
Do you think instead of removing this entirely, we should maybe conditionally set it for PHP versions < 8.1?
|
@jayedul, did you get a chance to check @Sidsector9 review? |
Sidsector9
approved these changes
Jul 26, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
@ini_set( 'auto_detect_line_endings', true );removed from csv import script since latest PHP versions manages line endings automatically.Closes #283
How to test the Change
Changelog Entry
Credits
Props @dhewer @jayedul
Checklist: