Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show raw target in redirect editor #330

Merged
merged 1 commit into from Jun 30, 2023
Merged

Show raw target in redirect editor #330

merged 1 commit into from Jun 30, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Jun 30, 2023

Description of the Change

Always show raw input value in the Redirect To field in individual rule edit screen. Previously it was set to show url uncoded value once it is saved which used to make it inconvenient for further edit.

Closes #201

How to test the Change

  • Edit individual redirect rule
  • Put some special characters in Redirect to field
  • Save and reload the editor
  • It still should show the exact value entered previously

Changelog Entry

Changed - Show raw redirect target in the rule editor

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul requested a review from a team as a code owner June 30, 2023 09:26
@jayedul jayedul self-assigned this Jun 30, 2023
@jayedul jayedul requested review from dkotter and removed request for a team June 30, 2023 09:26
@dkotter dkotter merged commit 0f016cd into develop Jun 30, 2023
11 checks passed
@dkotter dkotter deleted the fix/201 branch June 30, 2023 16:51
@jeffpaul jeffpaul added this to the 2.1.0 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to a url that includes square brackets []
3 participants