Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warning when calling the "wp safe-redirect-manager list" command #378

Merged
merged 1 commit into from Apr 25, 2024

Conversation

kmgalanakis
Copy link
Contributor

@kmgalanakis kmgalanakis commented Apr 25, 2024

Description of the Change

Fixed the following PHP warning when running the wp safe-redirect-manager list CLI command

[25-Apr-2024 14:37:37 UTC] PHP Warning:  SRM_WP_CLI::{closure}(): Argument #1 ($item) must be passed by reference, value given in /var/www/html/wp-content/plugins/safe-redirect-manager/inc/classes/class-srm-wp-cli.php on line 60
[25-Apr-2024 14:37:37 UTC] PHP Stack trace:
[25-Apr-2024 14:37:37 UTC] PHP   1. {main}() /usr/local/bin/wp:0
[25-Apr-2024 14:37:37 UTC] PHP   2. include() /usr/local/bin/wp:4
[25-Apr-2024 14:37:37 UTC] PHP   3. include() phar:///usr/local/bin/wp/php/boot-phar.php:20
[25-Apr-2024 14:37:37 UTC] PHP   4. WP_CLI\bootstrap() phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/wp-cli.php:32
[25-Apr-2024 14:37:37 UTC] PHP   5. WP_CLI\Bootstrap\LaunchRunner->process($state = class WP_CLI\Bootstrap\BootstrapState { private $state = ['context_manager' => class WP_CLI\ContextManager { ... }] }) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/bootstrap.php:83
[25-Apr-2024 14:37:37 UTC] PHP   6. WP_CLI\Runner->start() phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Bootstrap/LaunchRunner.php:28
[25-Apr-2024 14:37:37 UTC] PHP   7. WP_CLI\Runner->run_command_and_exit($help_exit_warning = *uninitialized*) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php:1269
[25-Apr-2024 14:37:37 UTC] PHP   8. WP_CLI\Runner->run_command($args = [0 => 'safe-redirect-manager', 1 => 'list'], $assoc_args = [], $options = *uninitialized*) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php:454
[25-Apr-2024 14:37:37 UTC] PHP   9. WP_CLI\Dispatcher\Subcommand->invoke($args = [], $assoc_args = [], $extra_args = []) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php:431
[25-Apr-2024 14:37:37 UTC] PHP  10. call_user_func:{phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/Subcommand.php:491}($callback = class Closure { public $static = ['callable' => [...]]; public $parameter = ['$args' => '<required>', '$assoc_args' => '<required>'] }, ...$args = variadic([])) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/Subcommand.php:491
[25-Apr-2024 14:37:37 UTC] PHP  11. WP_CLI\Dispatcher\CommandFactory::WP_CLI\Dispatcher\{closure:phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/CommandFactory.php:97-104}($args = [], $assoc_args = []) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/Subcommand.php:491
[25-Apr-2024 14:37:37 UTC] PHP  12. call_user_func:{phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/CommandFactory.php:100}($callback = [0 => class SRM_WP_CLI {  }, 1 => 'cli_list'], ...$args = variadic([])) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/CommandFactory.php:100
[25-Apr-2024 14:37:37 UTC] PHP  13. SRM_WP_CLI->cli_list($args = [], $assoc_args = []) phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Dispatcher/CommandFactory.php:100
[25-Apr-2024 14:37:37 UTC] PHP  14. array_map($callback = class Closure { public $static = ['assoc_args' => [...]]; public $this = class SRM_WP_CLI {  }; public $parameter = ['&$item' => '<required>'] }, $array = [0 => ['ID' => 5415, 'redirect_from' => '/test', 'redirect_to' => '/testing', 'status_code' => 302, 'message' => '', 'enable_regex' => FALSE, 'force_https' => '1', 'post_status' => 'publish']]) /var/www/html/wp-content/plugins/safe-redirect-manager/inc/classes/class-srm-wp-cli.php:60

Closes #377

How to test the Change

  1. Activate the Safe Redirect Manager plugin
  2. Add a redirect
  3. Run the wp safe-redirect-manager list CLI command and verify the output
  4. Verify that there is no PHP warning in the debug log file

Changelog Entry

Fixed - PHP warning when running the "wp safe-redirect-manager list" CLI command.

Credits

Props @kmgalanakis

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions github-actions bot added this to the 2.2.0 milestone Apr 25, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Apr 25, 2024
@dkotter dkotter merged commit 1ef16cd into develop Apr 25, 2024
15 checks passed
@dkotter dkotter deleted the fix/php-warning-with-cli-command branch April 25, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP warning when using wp cli command
2 participants