Merge pull request #174 from 10up/fix/75-slow-load-times-due-to-svgdi…

…mensions-v2 fix width and height metadata condition on svg_dimensions function
10up · Mar 19, 2024 · d4f9dcc · d4f9dcc
2 parents 7bdc8bc + 5900612
commit d4f9dcc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/safe-svg.php b/safe-svg.php
@@ -591,7 +591,7 @@ protected function svg_dimensions( $attachment_id ) {
 			$width    = 0;
 			$height   = 0;
 
-			if ( $svg && ! empty( $metadata['width'] ) && empty( $metadata['height'] ) ) {
+			if ( $svg && ! empty( $metadata['width'] ) && ! empty( $metadata['height'] ) ) {
 				$width  = floatval( $metadata['width'] );
 				$height = floatval( $metadata['height'] );
 			} elseif ( $svg ) {

diff --git a/tests/unit/test-safe-svg.php b/tests/unit/test-safe-svg.php
@@ -262,6 +262,9 @@ public function test_one_pixel_fix() {
 							),
 						),
 					),
+					array(
+						'filesize' => 1001, // wp_get_attachment_metadata response for ./files/svgNoDimensions.svg file doesn't contain dimensions and sizes array.
+					),
 				),
 			)
 		);