Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action summary added #124

Merged
merged 2 commits into from May 9, 2023
Merged

GH action summary added #124

merged 2 commits into from May 9, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented May 8, 2023

Description of the Change

Mochawesome reporter added for Cypress test report

Closes #98

Changelog Entry

Added - Mochawesome reporter added for Cypress test report

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this May 8, 2023
@jayedul jayedul marked this pull request as ready for review May 8, 2023 16:35
@jayedul jayedul requested review from jeffpaul and a team as code owners May 8, 2023 16:35
@jeffpaul jeffpaul added this to the 2.2.0 milestone May 8, 2023
@jeffpaul jeffpaul requested review from a team and peterwilsoncc and removed request for a team and jeffpaul May 8, 2023 16:39
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I pushed a change as noted inline.

- name: Upload artifacts
uses: actions/upload-artifact@v2
- name: Update summary
if: always()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed this in 424debc to ensure the summary is displayed for both successful and unsuccessful runs.

I reversed some assertions to trigger an unsuccessful run. This has since been removed from the history to remove noise.

@peterwilsoncc peterwilsoncc merged commit 46052cb into develop May 9, 2023
22 checks passed
@peterwilsoncc peterwilsoncc deleted the update/98 branch May 9, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a GH Actions summary
3 participants