Cypress Setup for E2E testing #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 17, 2022 22:03
# Conflicts: # package-lock.json # package.json
faisal-alvi
requested review from
a team and
Sidsector9
and removed request for
a team
Sidsector9
requested changes
May 25, 2022
| @@ -0,0 +1,14 @@ | |||
| describe('Check if avatar migration works', () => { | |||
There was a problem hiding this comment.
Although the title implies we are testing if migration works, the test itself doesn't perform any migration.
I think we can change it to:
describe( 'Avatar migration', () => {} )As the context for this test is migration of avatars.
And the test title can be set to:
it( 'Test no migration from WP User Avatar' );| cy.login(); | ||
| }); | ||
|
|
||
| it('Can admin upload, crop and select local avatar?', () => { |
There was a problem hiding this comment.
As we're not testing cropping in this test, it can be removed from the title.
There was a problem hiding this comment.
Actually, we are, the cropping action runs so fast that we don't see it:
Please let me know if this is not what you expected.
Sidsector9
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
wp_get_original_image_path()to support minimum WP version (i.e.4.6) and instead usedget_attached_filewhile clearing the avatar cache.Closes #111.
Alternate Designs
n/a
Possible Drawbacks
n/a
Verification Process
Make sure all tests added are running without fail.
Checklist:
Changelog Entry
Credits
Props @faisal-alvi @vikrampm1