Fix/116 admin.js file merged into the main JS file.

[faisal-alvi]

Description of the Change

• This PR fixes the issue of 404 to the admin.js file by moving the content from the admin.js file to the assets/js/simple-local-avatars.js file.
• Also removes the assets/js/admin.js file.
• The /assets folder was ignored in the .distignore file since Feature/add crop screen #83, which prevented the assets/js/admin.js file to be compiled at the time of release.
• The code is already approved in Add option to clear cache of user meta to remove image sizes that do not exist #90 so it should be good to go asap.

Closes #116

Alternate Designs

n/a

Verification Process

1. Switch to the develop branch.
2. Go to Settings > Discussion.
3. Click Clear cache.
4. The page reloads, instead of AJAX should run.
5. Move to this PR’s branch fix/116.
6. Build the project by npm run build.
7. Reload the page and click Clear cache.
8. The AJAX should run.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my change.
• All new and existing tests passed.

Changelog Entry

Fixed - Avatar cache not being cleared.

Credits

Props @thefrosty @jeffpaul @faisal-alvi

[thefrosty]

Without the removal of the assets line in .distignore: https://github.com/10up/simple-local-avatars/blob/develop/.distignore#L5 won't any JS files in there still be ignored on build and deploy to dot org?

Ahh I see, the other JS is in dist. 👍🏼

[peterwilsoncc]

Looks good to me, tests well.

[faisal-alvi]

@peterwilsoncc thanks for the quick review! somehow a portion of admin.js was missed in migration, #120 is raised for that.