Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/123 HTTP_REFERER is checked if set or not #129

Merged
merged 1 commit into from May 18, 2022
Merged

Fix/123 HTTP_REFERER is checked if set or not #129

merged 1 commit into from May 18, 2022

Conversation

faisal-alvi
Copy link
Member

Description of the Change

This PR simply adds an isset check for the $_SERVER['HTTP_REFERER'] to prevent PHP warnings.

Closes #123

Verification Process

Not required, though a quick check of the plugin functionalities would be appreciated.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - HTTP_REFERER is null and causing php warning.

Credits

Props @alireza-salehi @faisal-alvi

@faisal-alvi faisal-alvi added this to the 2.5.0 milestone May 17, 2022
@faisal-alvi faisal-alvi requested a review from a team May 17, 2022 14:29
@faisal-alvi faisal-alvi self-assigned this May 17, 2022
@faisal-alvi faisal-alvi requested review from peterwilsoncc and removed request for a team May 17, 2022 14:29
peterwilsoncc
peterwilsoncc approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jeffpaul jeffpaul merged commit 75b3372 into develop May 18, 2022
@jeffpaul jeffpaul deleted the fix/123 branch May 18, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

Assignees

@faisal-alvi faisal-alvi

Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

HTTP_REFERER is null and causing php warning
3 participants
@faisal-alvi @peterwilsoncc @jeffpaul