Host/Domain change support added for local avatar url #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffpaul
requested review from
a team and
ravinderk
and removed request for
a team
|
@jayedul Is this pull request ready for review? |
|
@ravinderk let's go ahead and proceed with review on the PR |
|
@faisal-alvi can you help with the PHPUnit failures here as well as general testing/code review to help get this ready for merge/release? |
Fatal error: Uncaught TypeError: array_key_exists(): Argument #2 ($array) must be of type array, string given in /var/www/html/wp-content/plugins/simple-local-avatars/includes/class-simple-local-avatars.php:342
|
The PHPUnit and Cypress test failures are fixed. Also, I've tested this in a single setup site, and it's working perfectly. I'd like to move forward with testing it in a multisite network setup before we proceed with the merge. Hopefully, I'll have some time next week to conduct that testing. |
faisal-alvi
approved these changes
Sep 25, 2023
|
Note: Unable to merge, requires one more approval. cc @ravinderk |
ravinderk
approved these changes
Sep 25, 2023
|
@faisal-alvi pr approved 🤞 |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Current domain/host will be used for local avatar URLs even after site migration.
Closes #64
How to test the Change
simple_local_avataruser meta, maybe in database directly for easy test.Changelog Entry
Credits
Props @jayedul
Checklist: