Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use required classes from global namespace. #162

Merged
merged 1 commit into from Sep 12, 2023
Merged

Use required classes from global namespace. #162

merged 1 commit into from Sep 12, 2023

Conversation

peterwilsoncc
Copy link
Contributor

@peterwilsoncc peterwilsoncc commented Sep 12, 2023 •
edited

Description of the Change

Prevents fatal errors in the admin-ajax functionality by adding use statements for classes in the global namespace.

Closes #161
Follow up to #153.

How to test the Change

  1. Go to WP Admin > Pages
  2. Open your browser's network tab in dev tools
  3. Create pages if required.
  4. Drag pages to re-order
  5. The network response is a 500 on develop, reordering should succeed on this branch.

Changelog Entry

Fixed - Fatal error following the introduction of a namespace.

Credits

Props @peterwilsoncc.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@peterwilsoncc peterwilsoncc self-assigned this Sep 12, 2023
@github-actions github-actions bot added this to the 2.6.0 milestone Sep 12, 2023
@peterwilsoncc peterwilsoncc marked this pull request as ready for review September 12, 2023 00:55
@peterwilsoncc peterwilsoncc requested a review from a team as a code owner September 12, 2023 00:55
@peterwilsoncc peterwilsoncc requested review from iamdharmesh and removed request for a team September 12, 2023 00:55
@github-actions github-actions bot added the needs:code-review This requires code review. label Sep 12, 2023
iamdharmesh
iamdharmesh approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching and fixing this @peterwilsoncc. LGTM! 🚀

@iamdharmesh iamdharmesh merged commit f462bc0 into develop Sep 12, 2023
14 checks passed
@iamdharmesh iamdharmesh deleted the fix/161-fatal-error branch September 12, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

Assignees

@peterwilsoncc peterwilsoncc

Labels
needs:code-review This requires code review.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

Fatal errors in admin-ajax request following introduction of namespace.
2 participants
@peterwilsoncc @iamdharmesh