Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode mdash character before rendering the title #53

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

dinhtungdu
Copy link
Collaborator

Description of the Change

Decode mdash character before rendering the title. This fixes #43.

Alternate Designs

Benefits

Make the UX less confusing when ordering child pages.

Possible Drawbacks

Verification Process

Checklist:

  1. Go to admin > Pages.
  2. Change order for child pages.
  3. See: After changing order, the title display — character correctly (same as before).
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@jeffpaul jeffpaul added this to the 2.3.4 milestone Apr 7, 2020
@jeffpaul jeffpaul added the type:bug Something isn’t working. label Apr 7, 2020
@jeffpaul jeffpaul mentioned this pull request Apr 7, 2020
18 tasks
@helen helen mentioned this pull request Apr 7, 2020
6 tasks
Copy link
Contributor

@helen helen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine for now, though we will probably trigger a warning about innerHTML again. The @wordpress/html-entities package does basically this though, just with an extra conditional usage of document.implementation.createHTMLDocument that falls back to this method. So, we should probably switch to that package later, I just don't want to introduce anything more complex in a hotfix release. I'm going to merge this, but let's open an issue for 2.4 to see about using the package and if that will avoid us getting dinged by automated scanners, and also an issue to automate the build process and stop committing the built JS file :)

@helen helen merged commit b8a9aec into develop Apr 8, 2020
@helen helen deleted the fix/43 branch April 8, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn’t working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted html entity when sorting child pages
3 participants