Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block: Podcast Services #154

Closed
1 task done
Tracked by #208
jeffpaul opened this issue Mar 2, 2022 · 12 comments · Fixed by #241
Closed
1 task done
Tracked by #208

Block: Podcast Services #154

jeffpaul opened this issue Mar 2, 2022 · 12 comments · Fixed by #241
Assignees
Labels
help wanted Extra attention is needed needs:design This requires design to resolve. needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

jeffpaul commented Mar 2, 2022

Is your enhancement related to a problem? Please describe.

Many podcast sites like to promote all the various podcast services where they syndicate their content (e.g., Pocket Casts, Apple Podcasts) on their homepage and within individual episode posts. There's currently no way to do this in the core Social Icons block nor any other quick way to do this using Simple Podcasting. So I propose a block that would allow a site owner to enable/disable the various podcast services and which would provide a visual icon for each of those enabled services. Open to what we call the block, "Podcast Services" doesn't feel quite right but is the best I can quickly come up with right now.

The following appear to be a good listing of podcast services to include:

  • Pocket Casts
  • Apple Podcasts
  • Google Podcasts
  • Stitcher
  • PlayerFM
  • Overcast
  • Pandora
  • Castro
  • TuneIn
  • Spotify
  • RSS (for the actual RSS feed of the podcast to be subscribed to in some other manner)

We'll probably want to include these services as new fields in the podcast settings so that the links to the podcast on each service is stored there and called into the block display for actual icon links.

Here's a good listing of the icons to use for each service (see "Player Icon Set"): https://www.podpage.com/badges/. As shown on the Apple Podcasts Identity Guidelines page, it might be nice to have black icons and white icons created from the full color versions on podpage.com and allow a site owner to chose from a full color, black, or white icon set for the display in the block.

Designs

Example icon display from WP Briefing:
Screen Shot 2022-03-02 at 1 37 29 PM

Describe alternatives you've considered

Await initial inclusion of these services in the core Social Icons block: WordPress/gutenberg#36755.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeffpaul jeffpaul added the type:enhancement New feature or request. label Mar 2, 2022
@jeffpaul
Copy link
Member Author

jeffpaul commented Mar 2, 2022

@cadic not sure if you feel this is worth milestoning into 1.4.0 or a future 1.5.0 release?

@jeffpaul jeffpaul added needs:design This requires design to resolve. needs:engineering This requires engineering to resolve. labels Mar 2, 2022
@cadic
Copy link
Contributor

cadic commented Mar 3, 2022

@jeffpaul let's keep it in 1.4.0 along with other podcast blocks, I know @Sidsector9 already started with one of these.

@cadic cadic added this to the 1.4.0 milestone Mar 3, 2022
@KajiiNarumi
Copy link

it would be enough to be able to add our own icons and services in the social link widget

@jeffpaul
Copy link
Member Author

jeffpaul commented Mar 10, 2022

Available sample icons (color, black, white) here: https://drive.google.com/drive/folders/1gJSLI9iXcLpQ___a0A7WQWXVL_uPsEgt. Noting that's a 10up internal link, so if someone outside 10up is interested in a PR for this I can ZIP those up and post directly to this issue. Credit for that imagery should go to Stephanie Campbell (@sncampbell).

@jeffpaul jeffpaul added the help wanted Extra attention is needed label Jun 6, 2022
@jeffpaul
Copy link
Member Author

Noting that @achchu93 is looking into this issue.

@jeffpaul
Copy link
Member Author

@achchu93 are you still tracking work on this such that you can push up a PR or should I look to pull 10upper availability to help on a PR?

@Sidsector9
Copy link
Member

@jeffpaul I'll raise the PR by today or tomorrow

@Sidsector9
Copy link
Member

Sidsector9 commented Nov 22, 2022

Progress update

Term meta settings for podcast platforms

Screenshot 2022-11-22 at 8 15 22 PM

Gutenberg Block is ready in the editor, finalising the frontend output.

Bonus features to add

  • Ability to reorder platforms

@Sidsector9 Sidsector9 self-assigned this Nov 22, 2022
@Sidsector9
Copy link
Member

Progress Update

Simple block implementation

Black

Screenshot 2022-11-23 at 1 20 22 PM

Color

Screenshot 2022-11-23 at 1 21 54 PM

@Sidsector9
Copy link
Member

@jeffpaul This block can have some few controls for customisation:

  • Icon size control
  • Layout options: linear | grid

@10up/open-source-practice have any thoughts on this?

@jeffpaul
Copy link
Member Author

I'm fine with no-to-minimal controls at first and ones can be added based on community input.

@jeffpaul
Copy link
Member Author

jeffpaul commented Jan 4, 2023

Noting that once this is released we'll want to assess if there are additional services that should be added, as I believe Amazon Music now includes podcasts and there may be others but will await community feedback before we iterate.

@Sidsector9 Sidsector9 modified the milestones: 1.4.0, 1.5.0 Jan 23, 2023
@jeffpaul jeffpaul modified the milestones: 1.5.0, 1.6.0 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:design This requires design to resolve. needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants