Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/154: add a Podcast Platforms Block #241

Merged
merged 13 commits into from Aug 18, 2023
Merged

feat/154: add a Podcast Platforms Block #241

merged 13 commits into from Aug 18, 2023

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jul 13, 2023

Closes #154

Description of the Change

This PR adds the Podcast Platforms block.

Podcasting Platforms block

Screenshot 2023-08-06 at 10 26 36 PM

Podcasting Platforms settings

Screenshot 2023-08-06 at 10 24 43 PM

Verification Process

  1. Add few podcasts.
  2. On the podcasts edit screen, scroll down to the Podcasting Platforms section.
  3. Set few platforms on which the podcast will be available.
  4. Add the Podcast Platforms block to a page and select the podcast from the search field.
  5. Confirm the output on the frontend, and also validate a11y.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @jeffpaul @Sidsector9

@Sidsector9 Sidsector9 requested a review from a team as a code owner July 13, 2023 13:13
@Sidsector9 Sidsector9 requested review from iamdharmesh and removed request for a team July 13, 2023 13:13
@Sidsector9 Sidsector9 marked this pull request as draft July 14, 2023 09:54
@jeffpaul jeffpaul added this to the 1.6.0 milestone Jul 14, 2023
@Sidsector9
Copy link
Member Author

@iamdharmesh this is ready for your review.

@Sidsector9 Sidsector9 marked this pull request as ready for review August 6, 2023 17:00
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and great work here @Sidsector9. Just added 2-3 minor notes to discuss other wise all good.

Thanks

simple-podcasting.php Show resolved Hide resolved
assets/js/blocks/podcast-platforms/edit.js Show resolved Hide resolved
'type' => 'platform_fields',
),
array(
'slug' => 'podcasting_icon_theme',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick:
I think keeping the icon theme option at block level is more user-friendly. Not a major issue, but love to hear your thoughts on this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamdharmesh that's a good idea, but something we can iteratively implement?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @Sidsector9, maybe we should create a follow-up issue for this?

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes @Sidsector9, LGTM!

@Sidsector9 Sidsector9 merged commit 9ac7790 into develop Aug 18, 2023
8 checks passed
@Sidsector9 Sidsector9 deleted the feat/154 branch August 18, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block: Podcast Services
3 participants