Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create podcast show in onboarding gives "Invalid taxonomy" error. #246

Closed
1 task done
iamdharmesh opened this issue Aug 8, 2023 · 1 comment · Fixed by #247
Closed
1 task done

Create podcast show in onboarding gives "Invalid taxonomy" error. #246

iamdharmesh opened this issue Aug 8, 2023 · 1 comment · Fixed by #247
Assignees
Labels
help wanted Extra attention is needed type:bug Something isn't working. type:good-first-issue Good for newcomers.
Milestone

Comments

@iamdharmesh
Copy link
Member

Describe the bug

Creating a podcast show in the onboarding first step gives an "Invalid taxonomy" error.

PHP Warning:  Use of undefined constant TAXONOMY_NAME - assumed 'TAXONOMY_NAME' (this will throw an Error in a future version of PHP) in /Users/******/public/wp-content/plugins/simple-podcasting/includes/create-podcast.php on line 128

It seems this issue is related to recent PR #238 in which we renamed Constant TAXONOMY_NAME to PODCASTING_TAXONOMY_NAME and need to update the constant to PODCASTING_TAXONOMY_NAME here.

$result = wp_insert_term(
$this->podcast_name,
TAXONOMY_NAME
);

Steps to Reproduce

  1. Activate the plugin for the first time on site or update the simple_podcasting_onboarding option to no, if it is already in use on site.
  2. Feel a podcast show details on onboarding and click on create.
  3. Notice that create podcast failed and the "Invalid taxonomy" error is shown.

Screenshots, screen recording, code snippet

image

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@iamdharmesh iamdharmesh added the type:bug Something isn't working. label Aug 8, 2023
@iamdharmesh iamdharmesh added this to the 1.6.0 milestone Aug 8, 2023
@iamdharmesh iamdharmesh added help wanted Extra attention is needed type:good-first-issue Good for newcomers. labels Aug 8, 2023
@kmgalanakis kmgalanakis self-assigned this Aug 14, 2023
@kmgalanakis
Copy link
Contributor

PR here: #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:bug Something isn't working. type:good-first-issue Good for newcomers.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants