Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP warning after missed constant renaming #247

Merged
merged 1 commit into from Aug 18, 2023
Merged

Fix PHP warning after missed constant renaming #247

merged 1 commit into from Aug 18, 2023

Conversation

kmgalanakis
Copy link
Contributor

Description of the Change

In this PR I'm fixing a PHP fatal error after a missed constant renaming.

Closes #246

Verification Process

  1. Activate the plugin for the first time on site or update the simple_podcasting_onboarding option to no, if it is already in use on site.
  2. Feel a podcast show details on onboarding and click on create.
  3. Verify that when the onboarding finishes there is no PHP warning in the debug log and that there is no notice about the failed creation of the podcast because of an "Invalid taxonomy" error.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - Fixed a PHP warning when creating a new podcast.

Credits

Props @kmgalanakis

@kmgalanakis kmgalanakis requested a review from a team as a code owner August 14, 2023 08:32
@kmgalanakis kmgalanakis requested review from peterwilsoncc and removed request for a team August 14, 2023 08:32
@kmgalanakis kmgalanakis mentioned this pull request Aug 14, 2023
Closed
1 task
@jeffpaul jeffpaul added this to the 1.6.0 milestone Aug 14, 2023
iamdharmesh
iamdharmesh approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @kmgalanakis. LGTM!

@iamdharmesh iamdharmesh merged commit d72b4b8 into develop Aug 18, 2023
8 checks passed
@iamdharmesh iamdharmesh deleted the fix/php-fatal-error-when-creating-new-podcast branch August 18, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdharmesh iamdharmesh iamdharmesh approved these changes

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc peterwilsoncc is a code owner automatically assigned from 10up/open-source-practice

Assignees

@kmgalanakis kmgalanakis

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Create podcast show in onboarding gives "Invalid taxonomy" error.
3 participants
@kmgalanakis @iamdharmesh @jeffpaul