Attempt to fix #134 is_feed called too early #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This tries to fix a PHP warning that occurs when using the latest version, it is too early to call
is_feed
on the main query, but we don't need to, we're handed the query object on a silver platter so lets use that instead.Closes #134
Alternate Designs
This seemed like the most straightforward way to fix it
Possible Drawbacks
¯\_(ツ)_/¯
Verification Process
None as of yet, just trying to be helpful and start the ball rolling by making the PR as quickly as possible
Checklist:
Changelog Entry
Credits
Props @tomjn