Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #134 is_feed called too early #135

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

tomjn
Copy link
Contributor

@tomjn tomjn commented Jan 6, 2022

Description of the Change

This tries to fix a PHP warning that occurs when using the latest version, it is too early to call is_feed on the main query, but we don't need to, we're handed the query object on a silver platter so lets use that instead.

Closes #134

Alternate Designs

This seemed like the most straightforward way to fix it

Possible Drawbacks

¯\_(ツ)_/¯

Verification Process

None as of yet, just trying to be helpful and start the ball rolling by making the PR as quickly as possible

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - Bug fix for is_feed being called too early

Credits

Props @tomjn

@jeffpaul jeffpaul requested a review from cadic January 6, 2022 15:49
@jeffpaul jeffpaul added this to the 1.3.0 milestone Jan 6, 2022
@cadic cadic merged commit d8545e0 into 10up:develop Jan 6, 2022
@cadic cadic modified the milestones: 1.3.0, 1.2.2 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_feed called too early
3 participants