Fix: failing Cypress test on WP Minimum #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadic
suggested changes
Apr 14, 2022
There was a problem hiding this comment.
@dinhtungdu thank you for adding this feature. I have few questions before we merge this.
cadic
approved these changes
Apr 15, 2022
cadic
approved these changes
Apr 15, 2022
2 tasks
cadic
added a commit
that referenced
this pull request
Apr 21, 2022
In #164 we have combined branch and pr Cypress workflows into a single e2e workflow, which has broken the badges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The test on WP 4.6 is failing because we run block tests in Classic Editor. This PR fixes that issue using the environment variable and
@cypress/skip-testpackage to skip block test on older versions of WP.Checklist:
Changelog Entry
Credits
Props @dinhtungdu