Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP 6.2 compatibility update #230

Merged
merged 3 commits into from Apr 18, 2023
Merged

WP 6.2 compatibility update #230

merged 3 commits into from Apr 18, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented Apr 6, 2023

Description of the Change

WP compatibility version upgraded to 6.2 and tests passed successfully.

Closes #226

Changelog Entry

Changed - WP compatibility version upgraded to 6.2

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this Apr 6, 2023
@jeffpaul jeffpaul added this to the 1.5.0 milestone Apr 11, 2023
@jeffpaul jeffpaul requested review from a team and peterwilsoncc and removed request for a team April 11, 2023 14:28
peterwilsoncc
peterwilsoncc approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I agree this still works in WP 6.2.

For merging in to trunk, I think only the readme update can be included in the commit to ensure the readme deploys. I'm not sure if the GH action handles ignored files.

@jayedul jayedul marked this pull request as ready for review April 17, 2023 06:02
@jayedul jayedul requested a review from a team as a code owner April 17, 2023 06:02
@jeffpaul
Copy link
Member

Correct, if there are ANY other files besides readme and assets updated then the Updater action will fail and NOT deploy anything to SVN.

@peterwilsoncc peterwilsoncc merged commit a55ddb5 into develop Apr 18, 2023
8 checks passed
@peterwilsoncc peterwilsoncc deleted the fix/226 branch April 18, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwilsoncc peterwilsoncc peterwilsoncc approved these changes

Assignees

@jayedul jayedul

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress
3 participants
@jayedul @jeffpaul @peterwilsoncc