Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check to ensure we have a valid PHP version before loading plugin functionality and output an admin notice if needed #248

Merged
merged 3 commits into from Aug 30, 2023

Conversation

kmgalanakis
Copy link
Contributor

@kmgalanakis kmgalanakis commented Aug 18, 2023

Description of the Change

In this PR, I'm adding a check for the minimum required PHP version before attempting to load the plugin files. If the condition is not met an admin notice is displayed and the plugin files are not loaded.

Closes #242

How to test the Change

  • To see the admin notice and have the plugin functionality not loaded, try to load the plugin on a site with PHP version lower that 7.4.

Changelog Entry

Added - Check for minimum required PHP version before loading the plugin
Changed - Bump WordPress "tested up to" version to 6.3

Credits

Props @kmgalanakis

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.
    c

…in functionality and output an admin notice if needed
@kmgalanakis kmgalanakis requested a review from a team as a code owner August 18, 2023 11:12
@kmgalanakis kmgalanakis requested review from peterwilsoncc and removed request for a team August 18, 2023 11:12
@kmgalanakis kmgalanakis self-assigned this Aug 18, 2023
@kmgalanakis kmgalanakis added this to the 1.6.0 milestone Aug 18, 2023
@dkotter dkotter linked an issue Aug 30, 2023 that may be closed by this pull request
@dkotter dkotter merged commit dbd93a8 into develop Aug 30, 2023
8 checks passed
@dkotter dkotter deleted the feature/add-php-checks branch August 30, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plugin hasn't been tested with the latest version of WordPress Add PHP checks
2 participants