Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

composer.lock should not be in .gitignore #37

Closed
cmmarslender opened this issue Jun 21, 2018 · 2 comments
Closed

composer.lock should not be in .gitignore #37

cmmarslender opened this issue Jun 21, 2018 · 2 comments

Comments

@cmmarslender
Copy link
Contributor

composer.lock file should be committed to our projects so that when we deploy them, we can run composer install and get a very specific set of package versions installed.

I could see maybe not wanting a composer.lock file in the scaffold repo, but we definitely want it in the repos that are generated as part of the scaffolding.

@dana-ross
Copy link
Contributor

It's a holdover from WP Make's templates. I agree it should be removed and we'll just make a point not to add it to the scaffold's repo /cc @timwright12

@dana-ross
Copy link
Contributor

Addressed in e2d3616

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants