Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit composer.lock to git #170

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Sep 16, 2022

Description of the Change

It's advantageous that composer.lock is commited to the repository. This introduces more consistency when dependencies are installed by individuals for projects depending on WP_Mock.

If someone wants to learn more about why this is important (if you have a better article, please post in comment!):

One notable update since #167 is maybe bumping PhpUnit to the ^9.5 constraint -- however the previous constraint >=7.0 made it so that 9.5.x could have been installed too.

I've also removed sebastian/comparator from dev dependencies. Not sure what this is used for since I couldn't find any reference to it. Maybe it was required in older phpunit versions?

As for behat and php-coveralls we might still use those later on.

Closes #153

How to test the Change

  • Review composer.json and composer.lock changes
  • Unit tests pass

Changelog Entry

  • composer.lock is commited to git

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly. n/a
  • I have added tests to cover my change. n/a
  • All new and existing tests pass.

@unfulvio-godaddy unfulvio-godaddy self-assigned this Sep 16, 2022
@github-actions
Copy link

Code Coverage

@unfulvio-godaddy unfulvio-godaddy requested a review from a team September 16, 2022 02:57
@unfulvio-godaddy unfulvio-godaddy added this to the 0.5.0 milestone Sep 16, 2022
@agibson-godaddy
Copy link
Contributor

Confirmed everything looks compatible back to PHP 7.3. (Nothing requiring PHP 8.0+, for instance.)

@agibson-godaddy agibson-godaddy merged commit ced9495 into trunk Sep 16, 2022
@agibson-godaddy agibson-godaddy deleted the commit-composer.lock-to-gh branch September 16, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install WP_Mock
2 participants