Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License to BSD-3 Clause #218

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jun 27, 2023

Summary

This PR updates the license of WP_Mock from a mix of MIT/GPL-2+ to be consistent with BSD-3 Clause only.

See #198 for a 6-month long discussion where we pinged past and present contributors/maintainers to notify them about the proposal, which has seen wide approval.

In the end, nothing prevents to make further amendments or change license again in the future, if the contributors think so and there's a benefit for all the contributors to do so.

Closes: #198

Details

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

Reviewer checklist

  • Documentation changes review
  • README.md, LICENSE.md, composer.json and items mentioned in this comment are consistently updated with BSD-3 Clause
  • README.md badges render correctly

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jun 27, 2023
@coveralls
Copy link

coveralls commented Jun 27, 2023

Coverage Status

coverage: 59.6%. remained the same when pulling ed430d7 on chore/update-license-to-bsd-3-clause into e5ac387 on trunk.

Comment on lines -29 to -31
* @package WP_Mock
* @copyright Copyright (c) 2013 10up (http://10up.com)
* @license MIT License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rows may still be worthwhile maintaining in this file, with an update from MIT to BSD-3-Clause to make it explicit in the main file what the licensing is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about 2160a9b (#218)

@unfulvio-godaddy unfulvio-godaddy requested review from jeffpaul and a team June 28, 2023 03:08
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for leading this licensing update!

@unfulvio-godaddy unfulvio-godaddy merged commit 1937bad into trunk Jun 28, 2023
9 checks passed
@unfulvio-godaddy unfulvio-godaddy deleted the chore/update-license-to-bsd-3-clause branch June 28, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change license from GPL 2.0 to BSD-3-Clause
3 participants