Add invokeInaccessibleMethod and getInaccessiblePropertyValue trait methods #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ashley Gibson <99189195+agibson-godaddy@users.noreply.github.com>
|
thanks for the phpdoc edit @agibson-godaddy -- makes sense to me; mind reapproving? thank you |
agibson-godaddy
approved these changes
Jul 3, 2023
agibson-godaddy
deleted the
chore/add-access-inaccessible-class-member-functions
branch
8 tasks
nmolham-godaddy
added a commit
that referenced
this pull request
Jul 6, 2023
# Summary <!-- Required --> While adding #220 I forgot one method (for @10up/godaddy-wp_mock these are basically the same as in MWC Tests, and with the addition of this PR we can drop them -- figured these are generally helpful and could be part of WP_Mock directly). This PR also updates the docs related to `AccessInaccessibleClassMembersTrait`. Fixes an unrelated flaky test. ## Contributor checklist <!-- Required --> <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you are unsure about any of these, please ask for clarification. We are here to help! --> - [x] I agree to follow this project's [**Code of Conduct**](https://github.com/10up/.github/blob/trunk/CODE_OF_CONDUCT.md). - [x] I have updated the documentation accordingly - [x] I have added tests to cover changes introduced by this pull request - [x] All new and existing tests pass ## Testing <!-- Required --> <!-- If applicable, add specific steps for the reviewer to perform as part of their testing process prior to approving this pull request. --> <!-- List any configuration requirements for testing. --> ### Reviewer checklist <!-- Required --> <!-- The following checklist is for the reviewer: add any steps that may be relevant while reviewing this pull request --> - [ ] Code changes review - [ ] Documentation changes review - [ ] Unit tests pass - [ ] Static analysis passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the
AccessInaccessibleClassMembersTraitused inWP_MockownTestCaseto invoke an inaccessible class method or get an inaccessible property value.Contributor checklist
Testing
Reviewer checklist