Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md (minor edits for grammar and content) #222

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Update README.md (minor edits for grammar and content) #222

merged 4 commits into from
Jul 3, 2023

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jun 30, 2023 •
edited by agibson-godaddy

Summary

Just a couple of edits for grammar and content which I missed while reviewing #217

  • There is no "Distributor"
  • Good to reference that we run tests against latest PHP as well
  • CHANGELOG > Changelog for consistency with other linked md files
  • "A complete listing of all notable changes are documented" > shouldn't it be "A complete listing of all notable changes is documented" since the subject is "a complete listing"?

Details

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jun 30, 2023
@unfulvio-godaddy unfulvio-godaddy requested review from jeffpaul and a team June 30, 2023 00:39
@unfulvio-godaddy unfulvio-godaddy added the Documentation Updates to documentation label Jun 30, 2023
agibson-godaddy
agibson-godaddy reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@agibson-godaddy agibson-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one slight suggestion.

README.md Outdated Show resolved Hide resolved
@unfulvio-godaddy @agibson-godaddy
Update README.md
0ac386a 
Co-authored-by: Ashley Gibson <99189195+agibson-godaddy@users.noreply.github.com>
@unfulvio-godaddy unfulvio-godaddy requested review from agibson-godaddy and a team July 3, 2023 10:40
@unfulvio-godaddy
Copy link
Member Author

thanks for checking @agibson-godaddy mind re-approving?

@coveralls
Copy link

Coverage Status

coverage: 59.84%. first build when pulling 1638cb2 on chore/update-wp-mock-readme into 4b56a8c on trunk.

@unfulvio-godaddy
Copy link
Member Author

looks like there might be a flaky test, but I believe I'm having this fixed in another PR

@unfulvio-godaddy unfulvio-godaddy merged commit aad7f54 into trunk Jul 3, 2023
9 checks passed
@unfulvio-godaddy unfulvio-godaddy deleted the chore/update-wp-mock-readme branch July 3, 2023 15:26
@jeffpaul jeffpaul added this to the v1.0.0 milestone Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agibson-godaddy agibson-godaddy agibson-godaddy approved these changes

@jeffpaul jeffpaul Awaiting requested review from jeffpaul

Assignees

@unfulvio-godaddy unfulvio-godaddy

Labels
Documentation Updates to documentation
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@unfulvio-godaddy @coveralls @agibson-godaddy @jeffpaul