Add predefined commonly used functions #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will prevent fatal errors from not defining expectations for commonly used methods that carry a prohibitively high cost-to-return ratio for mocking. Fixes #63
…defined before bootstrapping
|
@lkwdwrd Could I get a code review please? |
ericmann
approved these changes
Nov 19, 2016
bswatson
approved these changes
Nov 19, 2016
lkwdwrd
approved these changes
Nov 19, 2016
|
Looks good @johnpbloch - merge at will |
johnpbloch
pushed a commit
to johnpbloch/wp_mock
that referenced
this pull request
Feb 23, 2017
This prevents a bug in which patchwork tries to redefine any of the functions that were merged in 10up#76, but they were included before patchwork runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the work for #63